Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/payloads/singles/php/reverse_php.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method php_reverse_shell has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def php_reverse_shell

    if (!datastore['LHOST'] or datastore['LHOST'].empty?)
      # datastore is empty on msfconsole startup
      ipaddr = '127.0.0.1'
Severity: Major
Found in modules/payloads/singles/php/reverse_php.rb - About 2 hrs to fix

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      def initialize(info = {})
    super(merge_info(info,
      'Name'          => 'PHP Command Shell, Reverse TCP (via PHP)',
      'Description'   => 'Reverse PHP connect back shell with checks for disabled functions',
      'Author'        => 'egypt',
    Severity: Major
    Found in modules/payloads/singles/php/reverse_php.rb and 9 other locations - About 35 mins to fix
    modules/payloads/singles/cmd/unix/reverse_stub.rb on lines 14..30
    modules/payloads/singles/generic/ssh/interact.rb on lines 12..30
    modules/payloads/singles/php/reverse_perl.rb on lines 15..31
    modules/payloads/singles/python/shell_bind_tcp.rb on lines 10..26
    modules/payloads/singles/python/shell_reverse_sctp.rb on lines 13..31
    modules/payloads/singles/python/shell_reverse_tcp.rb on lines 15..31
    modules/payloads/singles/python/shell_reverse_tcp_ssl.rb on lines 15..31
    modules/payloads/singles/python/shell_reverse_udp.rb on lines 15..31
    modules/payloads/singles/ruby/shell_reverse_tcp_ssl.rb on lines 15..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status