Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/linux/gather/enum_protections.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method check_hardening has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_hardening
    if aslr_enabled?
      r = 'ASLR is enabled'
      print_good r
      report r
Severity: Major
Found in modules/post/linux/gather/enum_protections.rb - About 2 hrs to fix

    Method check_hardening has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_hardening
    if aslr_enabled?
      r = 'ASLR is enabled'
      print_good r
      report r
    Severity: Minor
    Found in modules/post/linux/gather/enum_protections.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_apps has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def find_apps
    apps = %w[
      truecrypt bulldog ufw iptables fw-settings logrotate logwatch
      chkrootkit clamav snort tiger firestarter avast lynis
      rkhunter tcpdump webmin jailkit pwgen proxychains bastille
    Severity: Minor
    Found in modules/post/linux/gather/enum_protections.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status