Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/escalate/aws_create_iam_user.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    # setup creds for making IAM API calls
    creds = metadata_creds
    if datastore['AccessKeyId'].empty?
      unless creds.include?('AccessKeyId')
Severity: Minor
Found in modules/post/multi/escalate/aws_create_iam_user.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    # setup creds for making IAM API calls
    creds = metadata_creds
    if datastore['AccessKeyId'].empty?
      unless creds.include?('AccessKeyId')
Severity: Major
Found in modules/post/multi/escalate/aws_create_iam_user.rb - About 2 hrs to fix

    Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Create an AWS IAM User',
    Severity: Minor
    Found in modules/post/multi/escalate/aws_create_iam_user.rb - About 1 hr to fix

      Method metadata_creds has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def metadata_creds
    # TODO: do it for windows/generic way
    cmd_out = cmd_exec('curl --version')
    if cmd_out =~ /^curl \d/
      url = "http://#{datastore['METADATA_IP']}/2012-01-12/meta-data/"
      Severity: Minor
      Found in modules/post/multi/escalate/aws_create_iam_user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status