Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/gather/grub_creds.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    @creds_hash = Hash.new
    @pass_hash = Hash.new

    targets = %w[
Severity: Major
Found in modules/post/multi/gather/grub_creds.rb - About 2 hrs to fix

    Method parse_passwd_from_file has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse_passwd_from_file(file)
    return unless readable?(file)

    print_status("Reading #{file}")
    Severity: Minor
    Found in modules/post/multi/gather/grub_creds.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_passwd_from_file has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def parse_passwd_from_file(file)
    return unless readable?(file)

    print_status("Reading #{file}")
    Severity: Minor
    Found in modules/post/multi/gather/grub_creds.rb - About 1 hr to fix

      Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Gather GRUB Password',
      Severity: Minor
      Found in modules/post/multi/gather/grub_creds.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    @creds_hash = Hash.new
    @pass_hash = Hash.new

    targets = %w[
        Severity: Minor
        Found in modules/post/multi/gather/grub_creds.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status