Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/gather/memory_search.rb

Summary

Maintainability
C
1 day
Test Coverage

Method print_result has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def print_result(result: nil)
    return unless result

    process_info = "#{result[:process]['name']} (pid: #{result[:process]['pid']})"
    unless result[:status] == :success
Severity: Minor
Found in modules/post/multi/gather/memory_search.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method print_result has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def print_result(result: nil)
    return unless result

    process_info = "#{result[:process]['name']} (pid: #{result[:process]['pid']})"
    unless result[:status] == :success
Severity: Major
Found in modules/post/multi/gather/memory_search.rb - About 2 hrs to fix

    Method save_loot has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def save_loot(results: [])
    return if results.empty?

    # Each result has a single response, which contains zero or more group tlv's.
    results.each do |result|
    Severity: Minor
    Found in modules/post/multi/gather/memory_search.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Memory Search',
    Severity: Minor
    Found in modules/post/multi/gather/memory_search.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status