Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/gather/ubiquiti_unifi_backup.rb

Summary

Maintainability
C
1 day
Test Coverage

Method find_save_files has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def find_save_files(d)
    case session.platform
    when 'windows'
      files = session.fs.dir.foreach(d)
    else
Severity: Minor
Found in modules/post/multi/gather/ubiquiti_unifi_backup.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    backup_locations = []
    sprop_locations = []

    vprint_status('OS Detected: %s' % session.platform)
Severity: Major
Found in modules/post/multi/gather/ubiquiti_unifi_backup.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    backup_locations = []
    sprop_locations = []

    vprint_status('OS Detected: %s' % session.platform)
    Severity: Minor
    Found in modules/post/multi/gather/ubiquiti_unifi_backup.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_save_files has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def find_save_files(d)
    case session.platform
    when 'windows'
      files = session.fs.dir.foreach(d)
    else
    Severity: Minor
    Found in modules/post/multi/gather/ubiquiti_unifi_backup.rb - About 1 hr to fix

      Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Multi Gather Ubiquiti UniFi Controller Backup',
      Severity: Minor
      Found in modules/post/multi/gather/ubiquiti_unifi_backup.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status