Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/recon/reverse_lookup.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    address = datastore['ADDRESS']
    range = datastore['RANGE']

    fail_with(Failure::BadConfig, 'ADDRESS or RANGE option must be set.') if address.blank? && range.blank?
Severity: Minor
Found in modules/post/multi/recon/reverse_lookup.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method win_resolve_ip has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def win_resolve_ip(ip)
    return unless Rex::Socket.dotted_ip?(ip)

    case session.type
    when 'powershell'
Severity: Minor
Found in modules/post/multi/recon/reverse_lookup.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method win_resolve_ip has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def win_resolve_ip(ip)
    return unless Rex::Socket.dotted_ip?(ip)

    case session.type
    when 'powershell'
Severity: Minor
Found in modules/post/multi/recon/reverse_lookup.rb - About 1 hr to fix

    Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    address = datastore['ADDRESS']
    range = datastore['RANGE']

    fail_with(Failure::BadConfig, 'ADDRESS or RANGE option must be set.') if address.blank? && range.blank?
    Severity: Minor
    Found in modules/post/multi/recon/reverse_lookup.rb - About 1 hr to fix

      Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Reverse Lookup IP Addresses',
      Severity: Minor
      Found in modules/post/multi/recon/reverse_lookup.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return
        Severity: Major
        Found in modules/post/multi/recon/reverse_lookup.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return host
          Severity: Major
          Found in modules/post/multi/recon/reverse_lookup.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/post/multi/recon/reverse_lookup.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status