Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/multi/recon/sudo_commands.rb

Summary

Maintainability
C
1 day
Test Coverage

Method parse_sudo has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_sudo(sudo_data)
    cmd_data = sudo_data.scan(/may run the following commands.*?$(.*)\z/m).flatten.first

    # remove leading whitespace from each line and remove linewraps
    formatted_data = ''
Severity: Minor
Found in modules/post/multi/recon/sudo_commands.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_sudo has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_sudo(sudo_data)
    cmd_data = sudo_data.scan(/may run the following commands.*?$(.*)\z/m).flatten.first

    # remove leading whitespace from each line and remove linewraps
    formatted_data = ''
Severity: Minor
Found in modules/post/multi/recon/sudo_commands.rb - About 1 hr to fix

    Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    if is_root?
      fail_with Failure::BadConfig, 'Session already has root privileges'
    end
    Severity: Minor
    Found in modules/post/multi/recon/sudo_commands.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    if is_root?
      fail_with Failure::BadConfig, 'Session already has root privileges'
    end
      Severity: Minor
      Found in modules/post/multi/recon/sudo_commands.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_eop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_eop(cmd)
    # drop args for simplicity (at the risk of false positives)
    cmd = cmd.split(/\s/).first

    if cmd.eql? 'ALL'
      Severity: Minor
      Found in modules/post/multi/recon/sudo_commands.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status