Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/networking/gather/enum_cisco.rb

Summary

Maintainability
D
1 day
Test Coverage

Method get_enable has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

  def get_enable(enable_pass, pass_file)
    if enable_pass
      found = false
      session.shell_command('enable').to_s.strip
      en_out = session.shell_command(enable_pass)
Severity: Minor
Found in modules/post/networking/gather/enum_cisco.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    # Get device prompt
    prompt = session.shell_command('')

    # Set terminal length to 0 so no paging is required
Severity: Major
Found in modules/post/networking/gather/enum_cisco.rb - About 2 hrs to fix

    Method get_enable has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_enable(enable_pass, pass_file)
    if enable_pass
      found = false
      session.shell_command('enable').to_s.strip
      en_out = session.shell_command(enable_pass)
    Severity: Minor
    Found in modules/post/networking/gather/enum_cisco.rb - About 1 hr to fix

      Method enum_exec has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def enum_exec(prompt)
    exec_commands = [
      {
        'cmd' => 'show ssh',
        'fn' => 'ssh_sessions',
      Severity: Minor
      Found in modules/post/networking/gather/enum_cisco.rb - About 1 hr to fix

        Method enum_priv has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def enum_priv(prompt)
    host = session.session_host
    port = session.session_port
    priv_commands = [
      {
        Severity: Minor
        Found in modules/post/networking/gather/enum_cisco.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    # Get device prompt
    prompt = session.shell_command('')

    # Set terminal length to 0 so no paging is required
          Severity: Minor
          Found in modules/post/networking/gather/enum_cisco.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method enum_priv has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def enum_priv(prompt)
    host = session.session_host
    port = session.session_port
    priv_commands = [
      {
          Severity: Minor
          Found in modules/post/networking/gather/enum_cisco.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case os_type
    when /IOS/
      ver_loc = store_loot('cisco.ios.version',
                           'text/plain',
                           session,
          Severity: Minor
          Found in modules/post/networking/gather/enum_cisco.rb and 1 other location - About 15 mins to fix
          modules/post/networking/gather/enum_juniper.rb on lines 72..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status