Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/ad_to_sqlite.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method run has a Cognitive Complexity of 473 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    max_search = datastore['MAX_SEARCH']

    db, dbfile = create_sqlite_db
    print_status "Temporary database created: #{dbfile.path}"
Severity: Minor
Found in modules/post/windows/gather/ad_to_sqlite.rb - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    max_search = datastore['MAX_SEARCH']

    db, dbfile = create_sqlite_db
    print_status "Temporary database created: #{dbfile.path}"
Severity: Major
Found in modules/post/windows/gather/ad_to_sqlite.rb - About 1 day to fix

    Method create_sqlite_db has 160 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_sqlite_db
    dbfile = Tempfile.new('ad_to_sqlite')
    db = SQLite3::Database.new(dbfile.path)
    db.type_translation = true
    Severity: Major
    Found in modules/post/windows/gather/ad_to_sqlite.rb - About 6 hrs to fix

      File ad_to_sqlite.rb has 429 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'sqlite3'
require 'tempfile'

class MetasploitModule < Msf::Post
  include Msf::Post::Windows::LDAP
      Severity: Minor
      Found in modules/post/windows/gather/ad_to_sqlite.rb - About 6 hrs to fix

        There are no issues that match your filters.

        Category
        Status