Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/checkvm.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Virtual Environment Detection',
Severity: Minor
Found in modules/post/windows/gather/checkvm.rb - About 1 hr to fix

    Method hyperv? has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def hyperv?
    physical_host = get_regval_str('HKLM\\SOFTWARE\\Microsoft\\Virtual Machine\\Guest\\Parameters', 'PhysicalHostNameFullyQualified')

    if physical_host
      report_note(
    Severity: Minor
    Found in modules/post/windows/gather/checkvm.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    print_status('Checking if the target is a Virtual Machine ...')
    @processes = get_processes
    @processes = [] if @processes.nil?
      Severity: Minor
      Found in modules/post/windows/gather/checkvm.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hyperv? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def hyperv?
    physical_host = get_regval_str('HKLM\\SOFTWARE\\Microsoft\\Virtual Machine\\Guest\\Parameters', 'PhysicalHostNameFullyQualified')

    if physical_host
      report_note(
      Severity: Minor
      Found in modules/post/windows/gather/checkvm.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method virtualbox? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def virtualbox?
    vboxprocs = [
      'vboxservice.exe',
      'vboxtray.exe'
    ]
      Severity: Minor
      Found in modules/post/windows/gather/checkvm.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

          return true if @system_product_name =~ /virtualbox/i
      Severity: Major
      Found in modules/post/windows/gather/checkvm.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return true if services_exist?(hyperv_services)
        Severity: Major
        Found in modules/post/windows/gather/checkvm.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return true if processes_exist?(vmwareprocs)
          Severity: Major
          Found in modules/post/windows/gather/checkvm.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status