rapid7/metasploit-framework

View on GitHub
modules/post/windows/gather/credentials/filezilla_server.rb

Summary

Maintainability
F
4 days
Test Coverage

Method parse_server has a Cognitive Complexity of 79 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_server(data)
    creds = []
    perms = []
    groups = []
    settings = {}
Severity: Minor
Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_filezilla_creds has 170 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_filezilla_creds(paths)
    fs_xml = "" # FileZilla Server.xml           - Settings for the local install
    fsi_xml = "" # FileZilla Server Interface.xml - Last server used with the interface
    credentials = Rex::Text::Table.new(
      'Header' => "FileZilla FTP Server Credentials",
Severity: Major
Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 6 hrs to fix

    File filezilla_server.rb has 399 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'rexml/document'
    
    class MetasploitModule < Msf::Post
      include Msf::Post::File
    
    
    Severity: Minor
    Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 5 hrs to fix

      Method parse_server has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def parse_server(data)
          creds = []
          perms = []
          groups = []
          settings = {}
      Severity: Major
      Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 4 hrs to fix

        Method get_filezilla_creds has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_filezilla_creds(paths)
            fs_xml = "" # FileZilla Server.xml           - Settings for the local install
            fsi_xml = "" # FileZilla Server Interface.xml - Last server used with the interface
            credentials = Rex::Text::Table.new(
              'Header' => "FileZilla FTP Server Credentials",
        Severity: Minor
        Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
            super(
              update_info(
                info,
                'Name' => 'Windows Gather FileZilla FTP Server Credential Collection',
        Severity: Minor
        Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 1 hr to fix

          Method check_filezilla has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def check_filezilla(locations)
              paths = []
              begin
                locations.each do |location|
                  print_status("Checking for Filezilla Server directory in: #{location}")
          Severity: Minor
          Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 1 hr to fix

            Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def run
                if session.type != "meterpreter"
                  print_error "Only meterpreter sessions are supported by this post module"
                  return
                end
            Severity: Minor
            Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 1 hr to fix

              Method check_filezilla has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def check_filezilla(locations)
                  paths = []
                  begin
                    locations.each do |location|
                      print_status("Checking for Filezilla Server directory in: #{location}")
              Severity: Minor
              Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def run
                  if session.type != "meterpreter"
                    print_error "Only meterpreter sessions are supported by this post module"
                    return
                  end
              Severity: Minor
              Found in modules/post/windows/gather/credentials/filezilla_server.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  keys.each do |key|
                    begin
                      root_key, base_key = session.sys.registry.splitkey(key)
                      value = session.sys.registry.query_value_direct(root_key, base_key, "install_dir")
                    rescue Rex::Post::Meterpreter::RequestError => e
              Severity: Major
              Found in modules/post/windows/gather/credentials/filezilla_server.rb and 2 other locations - About 50 mins to fix
              modules/post/windows/gather/credentials/mdaemon_cred_collector.rb on lines 72..80
              modules/post/windows/gather/credentials/purevpn_cred_collector.rb on lines 78..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    update_info(
                      info,
                      'Name' => 'Windows Gather FileZilla FTP Server Credential Collection',
                      'Description' => %q{ This module will collect credentials from the FileZilla FTP server if installed. },
                      'License' => MSF_LICENSE,
              Severity: Minor
              Found in modules/post/windows/gather/credentials/filezilla_server.rb and 1 other location - About 30 mins to fix
              modules/post/windows/gather/credentials/vnc.rb on lines 13..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  configuration << [
                    config['ftp_port'], config['ftp_bindip'], config['admin_port'], config['admin_bindip'],
                    config['admin_pass'], config['ssl'], config['ssl_certfile'], config['ssl_keypass']
                  ]
              Severity: Minor
              Found in modules/post/windows/gather/credentials/filezilla_server.rb and 1 other location - About 20 mins to fix
              plugins/nessus.rb on lines 837..837

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 27.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status