Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/imail.rb

Summary

Maintainability
C
1 day
Test Coverage

Method download_info has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def download_info(imail_user = '', imail_domain = '')
    base = 'HKLM\\SOFTWARE\\Ipswitch\\IMail'

    # Find domain(s)
    users_subkey = []
Severity: Minor
Found in modules/post/windows/gather/credentials/imail.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method download_info has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def download_info(imail_user = '', imail_domain = '')
    base = 'HKLM\\SOFTWARE\\Ipswitch\\IMail'

    # Find domain(s)
    users_subkey = []
Severity: Minor
Found in modules/post/windows/gather/credentials/imail.rb - About 1 hr to fix

    Method decode_password has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def decode_password(username = '', enc_password = '')
    # No point trying to decode if there's no username or password
    return '' if username.empty? || enc_password.empty?

    counter = 0
    Severity: Minor
    Found in modules/post/windows/gather/credentials/imail.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method report has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def report(users)
    credentials = Rex::Text::Table.new(
      'Header' => 'Ipswitch iMail User Credentials',
      'Indent' => 1,
      'Columns' =>
    Severity: Minor
    Found in modules/post/windows/gather/credentials/imail.rb - About 1 hr to fix

      Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather IPSwitch iMail User Data Enumeration',
      Severity: Minor
      Found in modules/post/windows/gather/credentials/imail.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status