Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/mdaemon_cred_collector.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method report_mdaemon_cred has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def report_mdaemon_cred(creds, port: 0, service: nil)
    # Build service information
    service_data = {
      # address: session.session_host, # Gives internal IP
      address: session.tunnel_peer.partition(':')[0], # Gives public IP
Severity: Minor
Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 1 hr to fix

    Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather MDaemonEmailServer Credential Cracking',
    Severity: Minor
    Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 1 hr to fix

      Method parse_userlist has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def parse_userlist(data)
    # creds  = ["['domain','mailbox','full_name','mail_dir','password']"]
    creds = []
    pop3 = []
    imap = []
      Severity: Minor
      Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 1 hr to fix

        Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
    if session.type != 'meterpreter'
      print_error('Only meterpreter sessions are supported by this post module')
      return
    end
        Severity: Minor
        Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    if session.type != 'meterpreter'
      print_error('Only meterpreter sessions are supported by this post module')
      return
    end
          Severity: Minor
          Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check_mdaemons has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def check_mdaemons(locations)
    tmp_filename = (0...12).map { rand(65..90).chr }.join
    begin
      locations.each do |location|
        vprint_status("Checking for Userlist in MDaemons directory at: #{location}")
          Severity: Minor
          Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              keys.each do |key|
      begin
        root_key, base_key = session.sys.registry.splitkey(key)
        value = session.sys.registry.query_value_direct(root_key, base_key, 'AppPath')
      rescue Rex::Post::Meterpreter::RequestError => e
          Severity: Major
          Found in modules/post/windows/gather/credentials/mdaemon_cred_collector.rb and 2 other locations - About 50 mins to fix
          modules/post/windows/gather/credentials/filezilla_server.rb on lines 64..72
          modules/post/windows/gather/credentials/purevpn_cred_collector.rb on lines 78..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 43.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status