Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/mssql_local_hashdump.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method store_hashes has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def store_hashes(hash_array, hash_type)
    # Save data
    loot_hashes = ''
    hash_array.each do |row|
      user, hash = row.strip.split
Severity: Minor
Found in modules/post/windows/gather/credentials/mssql_local_hashdump.rb - About 1 hr to fix

    Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Local SQL Server Hash Dump',
    Severity: Minor
    Found in modules/post/windows/gather/credentials/mssql_local_hashdump.rb - About 1 hr to fix

      Method get_sql_hash has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_sql_hash(instance_name)
    version_year = get_sql_version(instance_name)

    case version_year
    when '2000'
      Severity: Minor
      Found in modules/post/windows/gather/credentials/mssql_local_hashdump.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    # Set instance name (if specified)
    instance = datastore['INSTANCE'].to_s

    # Display target
        Severity: Minor
        Found in modules/post/windows/gather/credentials/mssql_local_hashdump.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status