Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/plsql_developer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method decrypt_pref has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  def decrypt_pref(file_name)
    file_contents = read_file(file_name)
    if file_contents.nil? || file_contents.empty?
      print_status "Skipping empty file: #{file_name}"
      return []
Severity: Minor
Found in modules/post/windows/gather/credentials/plsql_developer.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decrypt_pref has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def decrypt_pref(file_name)
    file_contents = read_file(file_name)
    if file_contents.nil? || file_contents.empty?
      print_status "Skipping empty file: #{file_name}"
      return []
Severity: Major
Found in modules/post/windows/gather/credentials/plsql_developer.rb - About 2 hrs to fix

    Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather PL/SQL Developer Connection Credentials',
    Severity: Minor
    Found in modules/post/windows/gather/credentials/plsql_developer.rb - About 1 hr to fix

      Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    print_status("Gather PL/SQL Developer Histories and Credentials on #{sysinfo['Computer']}")
    profiles = grab_user_profiles
    pref_paths = []
      Severity: Minor
      Found in modules/post/windows/gather/credentials/plsql_developer.rb - About 1 hr to fix

        Method parse_history has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_history(str)
    # @keys is defined in decrypt_pref, and this function is called by decrypt_pref after @keys is defined
    result = Hash[@keys.map { |k| [k.to_sym, ''] }]
    result[:Parent] = '-2'
        Severity: Minor
        Found in modules/post/windows/gather/credentials/plsql_developer.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status