Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/spark_im.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    grab_user_profiles.each do |user|
      next if user['AppData'].nil?

      accounts = user['AppData'] + '\\Spark\\spark.properties'
Severity: Minor
Found in modules/post/windows/gather/credentials/spark_im.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Spark IM Password Extraction',
Severity: Minor
Found in modules/post/windows/gather/credentials/spark_im.rb - About 1 hr to fix

    Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    grab_user_profiles.each do |user|
      next if user['AppData'].nil?

      accounts = user['AppData'] + '\\Spark\\spark.properties'
    Severity: Minor
    Found in modules/post/windows/gather/credentials/spark_im.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status