Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/enum_muicache.rb

Summary

Maintainability
C
1 day
Test Coverage

Method enumerate_muicache has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def enumerate_muicache(muicache_reg_keys, sys_users, sys_paths, muicache, hive_file)
    results = []

    all_user_entries = sys_users.zip(muicache_reg_keys, sys_paths)
Severity: Minor
Found in modules/post/windows/gather/enum_muicache.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    print_status('Starting to enumerate MUICache registry keys...')
    version = get_version_info

    if version.xp_or_2003? && is_admin?
Severity: Minor
Found in modules/post/windows/gather/enum_muicache.rb - About 1 hr to fix

    Method hive_parser has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def hive_parser(local_hive_copy, muicache, user)
    results = []
    print_status('Parsing registry content...')
    err_msg = 'Error parsing hive. Unable to continue.'
    hive = Rex::Registry::Hive.new(local_hive_copy)
    Severity: Minor
    Found in modules/post/windows/gather/enum_muicache.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hive_parser has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def hive_parser(local_hive_copy, muicache, user)
    results = []
    print_status('Parsing registry content...')
    err_msg = 'Error parsing hive. Unable to continue.'
    hive = Rex::Registry::Hive.new(local_hive_copy)
    Severity: Minor
    Found in modules/post/windows/gather/enum_muicache.rb - About 1 hr to fix

      Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Enum User MUICache',
      Severity: Minor
      Found in modules/post/windows/gather/enum_muicache.rb - About 1 hr to fix

        Method process_hive has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def process_hive(sys_path, user, muicache, hive_file)
    user_home_path = expand_path(sys_path)
    hive_path = user_home_path + hive_file
    ntuser_status = file_exist?(hive_path)
        Severity: Minor
        Found in modules/post/windows/gather/enum_muicache.rb - About 1 hr to fix

          Method enumerate_muicache has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def enumerate_muicache(muicache_reg_keys, sys_users, sys_paths, muicache, hive_file)
          Severity: Minor
          Found in modules/post/windows/gather/enum_muicache.rb - About 35 mins to fix

            Method find_user_names has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def find_user_names
    user_names = []
    user_homedir_paths = []
    user_sids = []
            Severity: Minor
            Found in modules/post/windows/gather/enum_muicache.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_hive has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def process_hive(sys_path, user, muicache, hive_file)
    user_home_path = expand_path(sys_path)
    hive_path = user_home_path + hive_file
    ntuser_status = file_exist?(hive_path)
            Severity: Minor
            Found in modules/post/windows/gather/enum_muicache.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def run
    print_status('Starting to enumerate MUICache registry keys...')
    version = get_version_info

    if version.xp_or_2003? && is_admin?
            Severity: Minor
            Found in modules/post/windows/gather/enum_muicache.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Enum User MUICache',
            Severity: Major
            Found in modules/post/windows/gather/enum_muicache.rb and 4 other locations - About 35 mins to fix
            modules/post/windows/gather/credentials/avira_password.rb on lines 9..34
            modules/post/windows/gather/credentials/epo_sql.rb on lines 12..38
            modules/post/windows/gather/credentials/smartftp.rb on lines 11..38
            modules/post/windows/gather/credentials/wsftp_client.rb on lines 11..36

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      if key[0] != '@' && key != 'LangID' && !key.nil?
            result = check_file_exists(key, user)
            results << result unless result.nil?
          end
            Severity: Minor
            Found in modules/post/windows/gather/enum_muicache.rb and 1 other location - About 15 mins to fix
            modules/post/windows/gather/enum_muicache.rb on lines 216..219

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if key[0] != '@' && key != 'LangID' && !key.nil?
        result = check_file_exists(key, user)
        results << result unless result.nil?
      end
            Severity: Minor
            Found in modules/post/windows/gather/enum_muicache.rb and 1 other location - About 15 mins to fix
            modules/post/windows/gather/enum_muicache.rb on lines 121..124

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status