Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/enum_powershell_env.rb

Summary

Maintainability
C
1 day
Test Coverage

Method enum_powershell has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def enum_powershell
    unless registry_enumkeys('HKLM\\SOFTWARE\\Microsoft').include?('PowerShell')
      print_error('PowerShell is not installed on this system.')
      return
    end
Severity: Minor
Found in modules/post/windows/gather/enum_powershell_env.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enum_powershell has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def enum_powershell
    unless registry_enumkeys('HKLM\\SOFTWARE\\Microsoft').include?('PowerShell')
      print_error('PowerShell is not installed on this system.')
      return
    end
Severity: Major
Found in modules/post/windows/gather/enum_powershell_env.rb - About 2 hrs to fix

    Method enum_users has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def enum_users
    users = []

    system_drive = get_env('SystemDrive').to_s.strip
    Severity: Minor
    Found in modules/post/windows/gather/enum_powershell_env.rb - About 1 hr to fix

      Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather PowerShell Environment Setting Enumeration',
      Severity: Minor
      Found in modules/post/windows/gather/enum_powershell_env.rb - About 1 hr to fix

        Method enum_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def enum_users
    users = []

    system_drive = get_env('SystemDrive').to_s.strip
        Severity: Minor
        Found in modules/post/windows/gather/enum_powershell_env.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status