Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/local_admin_search_enum.rb

Summary

Maintainability
C
1 day
Test Coverage

Method setup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def setup
    super

    # This datastore option can be modified during runtime.
    # Saving it here so the modified value remains with this module.
Severity: Minor
Found in modules/post/windows/gather/local_admin_search_enum.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enum_users has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def enum_users(host)
    userlist = Array.new

    begin
      # Connect to host and enumerate logged in users
Severity: Minor
Found in modules/post/windows/gather/local_admin_search_enum.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enum_users has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def enum_users(host)
    userlist = Array.new

    begin
      # Connect to host and enumerate logged in users
Severity: Minor
Found in modules/post/windows/gather/local_admin_search_enum.rb - About 1 hr to fix

    Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Local Admin Search',
    Severity: Minor
    Found in modules/post/windows/gather/local_admin_search_enum.rb - About 1 hr to fix

      Method enum_groups has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def enum_groups(user)
    grouplist = ''

    dc = "\\\\#{@domain_controller}"
    begin
      Severity: Minor
      Found in modules/post/windows/gather/local_admin_search_enum.rb - About 1 hr to fix

        Method setup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def setup
    super

    # This datastore option can be modified during runtime.
    # Saving it here so the modified value remains with this module.
        Severity: Minor
        Found in modules/post/windows/gather/local_admin_search_enum.rb - About 1 hr to fix

          Method connect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def connect(host)
    if @adv.nil?
      return
    end
          Severity: Minor
          Found in modules/post/windows/gather/local_admin_search_enum.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status