Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/screen_spy.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    host = session.session_host
    screenshot = Msf::Config.config_directory + '/logs/' + host + '.jpg'

    # If no PID is specified, don't migrate.
Severity: Minor
Found in modules/post/windows/gather/screen_spy.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    host = session.session_host
    screenshot = Msf::Config.config_directory + '/logs/' + host + '.jpg'

    # If no PID is specified, don't migrate.
Severity: Major
Found in modules/post/windows/gather/screen_spy.rb - About 2 hrs to fix

    Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Gather Screen Spy',
    Severity: Minor
    Found in modules/post/windows/gather/screen_spy.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/post/windows/gather/screen_spy.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status