Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/manage/enable_support_account.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    reg_key = 'HKLM\\SAM\\SAM\\Domains\\Account\\Users'

    unless is_system?
      if datastore['GETSYSTEM']
Severity: Minor
Found in modules/post/windows/manage/enable_support_account.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    reg_key = 'HKLM\\SAM\\SAM\\Domains\\Account\\Users'

    unless is_system?
      if datastore['GETSYSTEM']
Severity: Major
Found in modules/post/windows/manage/enable_support_account.rb - About 2 hrs to fix

    Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Manage Trojanize Support Account',
    Severity: Minor
    Found in modules/post/windows/manage/enable_support_account.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return
      Severity: Major
      Found in modules/post/windows/manage/enable_support_account.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/post/windows/manage/enable_support_account.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return
          Severity: Major
          Found in modules/post/windows/manage/enable_support_account.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status