Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
plugins/openvas.rb

Summary

Maintainability
D
3 days
Test Coverage

File openvas.rb has 474 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'openvas-omp'

module Msf
  class Plugin::OpenVAS < Msf::Plugin
    class OpenVASCommandDispatcher
Severity: Minor
Found in plugins/openvas.rb - About 7 hrs to fix

    Class OpenVASCommandDispatcher has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class OpenVASCommandDispatcher
      include Msf::Ui::Console::CommandDispatcher

      def name
        'OpenVAS'
    Severity: Minor
    Found in plugins/openvas.rb - About 3 hrs to fix

      Method cmd_openvas_help has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def cmd_openvas_help
        print_status('openvas_help                  Display this help')
        print_status('openvas_debug                 Enable/Disable debugging')
        print_status('openvas_version               Display the version of the OpenVAS server')
        print_status
      Severity: Minor
      Found in plugins/openvas.rb - About 1 hr to fix

        Method cmd_openvas_connect has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def cmd_openvas_connect(*args)
        # Is the database configured?
        if !database?
          print_error('No database has been configured.')
          return
        Severity: Minor
        Found in plugins/openvas.rb - About 1 hr to fix

          Method cmd_openvas_connect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def cmd_openvas_connect(*args)
        # Is the database configured?
        if !database?
          print_error('No database has been configured.')
          return
          Severity: Minor
          Found in plugins/openvas.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method cmd_openvas_task_delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def cmd_openvas_task_delete(*args)
        return unless openvas?

        if args?(args, 2)
          Severity: Minor
          Found in plugins/openvas.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return
          Severity: Major
          Found in plugins/openvas.rb - About 30 mins to fix

            Method cmd_openvas_report_download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_report_download(*args)
        return unless openvas?

        if args?(args, 4)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_create(*args)
        return unless openvas?

        if args?(args, 4)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_report_import has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_report_import(*args)
        return unless openvas?

        if args?(args, 2)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_start(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_target_delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_target_delete(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_stop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_stop(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_resume has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_resume(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_pause has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_pause(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_report_delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_report_delete(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_debug has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_debug(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_task_resume_or_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_task_resume_or_start(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_openvas_target_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cmd_openvas_target_create(*args)
        return unless openvas?

        if args?(args, 3)
          begin
            Severity: Minor
            Found in plugins/openvas.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  def args?(args, min = 1, max = nil)
        if !max then max = min end
        if ((args.length < min) || (args.length > max) || (args[0] == '-h'))
          return false
        end
            Severity: Minor
            Found in plugins/openvas.rb and 1 other location - About 25 mins to fix
            plugins/besecure.rb on lines 66..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 31.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def cmd_openvas_report_delete(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 1 other location - About 25 mins to fix
            plugins/openvas.rb on lines 230..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 30.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def cmd_openvas_target_delete(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 1 other location - About 25 mins to fix
            plugins/openvas.rb on lines 482..494

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 30.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                  def cmd_openvas_task_stop(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 4 other locations - About 25 mins to fix
            plugins/openvas.rb on lines 332..343
            plugins/openvas.rb on lines 362..373
            plugins/openvas.rb on lines 377..388
            plugins/openvas.rb on lines 392..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                  def cmd_openvas_task_pause(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 4 other locations - About 25 mins to fix
            plugins/openvas.rb on lines 332..343
            plugins/openvas.rb on lines 347..358
            plugins/openvas.rb on lines 377..388
            plugins/openvas.rb on lines 392..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                  def cmd_openvas_task_resume(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 4 other locations - About 25 mins to fix
            plugins/openvas.rb on lines 332..343
            plugins/openvas.rb on lines 347..358
            plugins/openvas.rb on lines 362..373
            plugins/openvas.rb on lines 392..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                  def cmd_openvas_task_start(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 4 other locations - About 25 mins to fix
            plugins/openvas.rb on lines 347..358
            plugins/openvas.rb on lines 362..373
            plugins/openvas.rb on lines 377..388
            plugins/openvas.rb on lines 392..403

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                  def cmd_openvas_task_resume_or_start(*args)
        return unless openvas?

        if args?(args)
          begin
            Severity: Minor
            Found in plugins/openvas.rb and 4 other locations - About 25 mins to fix
            plugins/openvas.rb on lines 332..343
            plugins/openvas.rb on lines 347..358
            plugins/openvas.rb on lines 362..373
            plugins/openvas.rb on lines 377..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status