rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/get_filezilla_creds.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method extract_saved_creds has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def extract_saved_creds(path,xml_file)
  accounts_xml = ""
  creds = ""
  print_status("Reading #{xml_file} file...")
  ### modified to use pidgin_path, which already has .purple in it
Severity: Minor
Found in scripts/meterpreter/get_filezilla_creds.rb - About 1 hr to fix

    Method extract_saved_creds has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def extract_saved_creds(path,xml_file)
      accounts_xml = ""
      creds = ""
      print_status("Reading #{xml_file} file...")
      ### modified to use pidgin_path, which already has .purple in it
    Severity: Minor
    Found in scripts/meterpreter/get_filezilla_creds.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method enum_users has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def enum_users(os)
      users = []
    
      path4users = ""
      sysdrv = @client.sys.config.getenv('SystemDrive')
    Severity: Minor
    Found in scripts/meterpreter/get_filezilla_creds.rb - About 1 hr to fix

      Method enum_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def enum_users(os)
        users = []
      
        path4users = ""
        sysdrv = @client.sys.config.getenv('SystemDrive')
      Severity: Minor
      Found in scripts/meterpreter/get_filezilla_creds.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def enum_users(os)
        users = []
      
        path4users = ""
        sysdrv = @client.sys.config.getenv('SystemDrive')
      Severity: Major
      Found in scripts/meterpreter/get_filezilla_creds.rb and 1 other location - About 2 hrs to fix
      scripts/meterpreter/get_pidgin_creds.rb on lines 151..181

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      def check_filezilla(path)
        found = nil
        @client.fs.dir.foreach(path) do |x|
          next if x =~ /^(\.|\.\.)$/
          if x =~ (/FileZilla/)
      Severity: Minor
      Found in scripts/meterpreter/get_filezilla_creds.rb and 1 other location - About 25 mins to fix
      scripts/meterpreter/get_pidgin_creds.rb on lines 60..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status