Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/schtasksabuse.rb

Summary

Maintainability
C
1 day
Test Coverage

Method abuse has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

def abuse(session,targets,commands,username,password,delay)
  #for each target
  targets.each do |t|
    next if t.strip.length < 1
    next if t[0,1] == "#"
Severity: Minor
Found in scripts/meterpreter/schtasksabuse.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method abuse has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def abuse(session,targets,commands,username,password,delay)
  #for each target
  targets.each do |t|
    next if t.strip.length < 1
    next if t[0,1] == "#"
Severity: Major
Found in scripts/meterpreter/schtasksabuse.rb - About 2 hrs to fix

    Method abuse has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def abuse(session,targets,commands,username,password,delay)
    Severity: Minor
    Found in scripts/meterpreter/schtasksabuse.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status