Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/winenum.rb

Summary

Maintainability
F
3 days
Test Coverage

File winenum.rb has 539 lines of code (exceeds 250 allowed). Consider refactoring.
Open

@client = client
opts = Rex::Parser::Arguments.new(
  "-h" => [ false, "Help menu." ],
  "-m" => [ false, "Migrate the Meterpreter Session from it current process to a new cmd.exe before doing anything" ],
  "-r" => [ false, "Dump, compress and download entire Registry" ],
Severity: Major
Found in scripts/meterpreter/winenum.rb - About 1 day to fix

    Method wmicexec has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def wmicexec(wmiccmds= nil)
  print_status("Running WMIC Commands ....")
  i, a = 0, []
  @client.response_timeout=120
    Severity: Minor
    Found in scripts/meterpreter/winenum.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findprogs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def findprogs()
  print_status("Extracting software list from registry")
  proglist = ""
  threadnum = 0
  a = []
    Severity: Minor
    Found in scripts/meterpreter/winenum.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wmicexec has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def wmicexec(wmiccmds= nil)
  print_status("Running WMIC Commands ....")
  i, a = 0, []
  @client.response_timeout=120
    Severity: Minor
    Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

      Method chkvm has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def chkvm()
  check = nil
  vmout = ''
  info = @client.sys.config.sysinfo
  print_status "Checking if #{info['Computer']} is a Virtual Machine ........"
      Severity: Minor
      Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

        Method regdump has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def regdump(pathoflogs,filename)
  host,port = @client.session_host, @client.session_port
  #This variable will only contain garbage, it is to make sure that the channel is not closed while the reg is being dumped and compress
  garbage = ''
  hives = %w{HKCU HKLM HKCC HKCR HKU}
        Severity: Minor
        Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

          Method list_exec has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          def list_exec(cmdlst)
  print_status("Running Command List ...")
  i = 0
  a =[]
  @client.response_timeout=120
          Severity: Minor
          Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method listtokens has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          def listtokens()
  begin
    print_status("Getting Tokens...")
    dt = ''
    @client.core.use("incognito")
          Severity: Minor
          Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

            Method chkvm has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            def chkvm()
  check = nil
  vmout = ''
  info = @client.sys.config.sysinfo
  print_status "Checking if #{info['Computer']} is a Virtual Machine ........"
            Severity: Minor
            Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method findprogs has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            def findprogs()
  print_status("Extracting software list from registry")
  proglist = ""
  threadnum = 0
  a = []
            Severity: Minor
            Found in scripts/meterpreter/winenum.rb - About 1 hr to fix

              Method regdump has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def regdump(pathoflogs,filename)
  host,port = @client.session_host, @client.session_port
  #This variable will only contain garbage, it is to make sure that the channel is not closed while the reg is being dumped and compress
  garbage = ''
  hives = %w{HKCU HKLM HKCC HKCR HKU}
              Severity: Minor
              Found in scripts/meterpreter/winenum.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method listtokens has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def listtokens()
  begin
    print_status("Getting Tokens...")
    dt = ''
    @client.core.use("incognito")
              Severity: Minor
              Found in scripts/meterpreter/winenum.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              commands = [
  'cmd.exe /c set',
  'arp -a',
  'ipconfig /all',
  'ipconfig /displaydns',
              Severity: Minor
              Found in scripts/meterpreter/winenum.rb and 5 other locations - About 15 mins to fix
              modules/auxiliary/scanner/http/file_same_name_dir.rb on lines 37..62
              modules/auxiliary/scanner/http/prev_dir_same_name_file.rb on lines 34..59
              modules/auxiliary/scanner/snmp/snmp_enum.rb on lines 35..46
              modules/exploits/windows/iis/ms03_007_ntdll_webdav.rb on lines 137..163
              modules/post/windows/gather/enum_ms_product_keys.rb on lines 105..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status