rapid7/metasploit-framework

View on GitHub
tools/dev/report_generation/support_matrix/generate.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method table has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def table
      sorted_sessions = @data.fetch(:sessions, []).sort_by { |session| session[:session_type] }

      # Group into buckets, and prioritize sort order
      extension_names = [
Severity: Major
Found in tools/dev/report_generation/support_matrix/generate.rb - About 2 hrs to fix

    Method extract_data has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.extract_data(options)
        if options[:allure_data]
          results_directory = options[:allure_data]
    
          test_result_files = Dir['**/*-result.json', base: results_directory]
    Severity: Minor
    Found in tools/dev/report_generation/support_matrix/generate.rb - About 1 hr to fix

      Method extract_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.extract_data(options)
          if options[:allure_data]
            results_directory = options[:allure_data]
      
            test_result_files = Dir['**/*-result.json', base: results_directory]
      Severity: Minor
      Found in tools/dev/report_generation/support_matrix/generate.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status