rapid7/nexpose-client

View on GitHub
lib/eso/filter.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method process_operands has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def process_operands(operands)
        @operands =
          if ["IS_EMPTY", "IS_NOT_EMPTY"].include? @operator
            nil
          elsif @type == "#{Eso::Filters::IP_ADDRESS}_ITEM" ||
Severity: Minor
Found in lib/eso/filter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_hash has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def to_hash
        hash = {
          valueClass: "Object",
          objectType: @type,
          properties: {
Severity: Minor
Found in lib/eso/filter.rb - About 1 hr to fix

    Method process_operands has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def process_operands(operands)
            @operands =
              if ["IS_EMPTY", "IS_NOT_EMPTY"].include? @operator
                nil
              elsif @type == "#{Eso::Filters::IP_ADDRESS}_ITEM" ||
    Severity: Minor
    Found in lib/eso/filter.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status