Sign upLogin

rapid7/nexpose-client

View on GitHub
Star
lib/nexpose/silo.rb

Summary

Maintainability
B
5 hrs
Test Coverage

File silo.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Nexpose

  class Connection
    include XMLUtils
Severity: Minor
Found in lib/nexpose/silo.rb - About 2 hrs to fix

    Method parse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.parse(xml)
        new do |merchant|
          merchant.acquirer_relationship = xml.attributes['acquirer-relationship'].to_s.chomp.eql?('true')
          merchant.agent_relationship    = xml.attributes['agent-relationship'].to_s.chomp.eql?('true')
          merchant.ecommerce             = xml.attributes['ecommerce'].to_s.chomp.eql?('true')
    Severity: Minor
    Found in lib/nexpose/silo.rb - About 1 hr to fix

      Method as_xml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def as_xml
        xml = super
        xml.name = 'Merchant'
        xml.add_attributes({ 'acquirer-relationship' => @acquirer_relationship, 'agent-relationship' => @agent_relationship,
                             'ecommerce' => @ecommerce, 'grocery' => @grocery, 'mail-order' => @mail_order })
      Severity: Minor
      Found in lib/nexpose/silo.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        class Connection
    include XMLUtils

    # Retrieve a list of all silos the user is authorized to view or manage.
    #
      Severity: Major
      Found in lib/nexpose/silo.rb and 2 other locations - About 50 mins to fix
      lib/nexpose/multi_tenant_user.rb on lines 3..28
      lib/nexpose/silo_profile.rb on lines 3..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def self.load(connection, id)
      r = connection.execute(connection.make_xml('SiloConfigRequest', { 'silo-id' => id }), '1.2')

      if r.success
        r.res.elements.each('SiloConfigResponse/SiloConfig') do |config|
      Severity: Minor
      Found in lib/nexpose/silo.rb and 2 other locations - About 20 mins to fix
      lib/nexpose/multi_tenant_user.rb on lines 150..158
      lib/nexpose/silo_profile.rb on lines 65..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status