app/controllers/users_controller.rb
Method update
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def update
authorize! :disable, @user if params[:user].include?(:disabled)
authorize! :update, @user if params[:user].except(:disabled).present?
params[:verify] = !@user.verified?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method register_unverified
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def register_unverified
respond_to do |format|
format.json do
params[:user] = JSON.parse(params[:user]) if params[:user].is_a?(String)
return render(:json => {:response => 'ok'}) unless User.find_by_user_name(params[:user]['user_name']).nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"