Sign upLogin

rapidftr/RapidFTR

View on GitHub
Star

Showing 110 of 110 total issues

Method execute_search has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def execute_search
      search = Search.for(Child)

      @criteria.each do |criterion|
        search.fulltext_by [criterion[:field]], criterion[:value]
Severity: Minor
Found in app/models/forms/search_form.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method return_partial_hash has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def return_partial_hash(change, field, history, model = nil)
    if field == 'photo_keys'
      return {:partial => 'shared/histories/photo_history_change',
              :locals => {
                :new_photos => change['added'],
Severity: Minor
Found in app/helpers/histories_helper.rb - About 1 hr to fix

    Method to_csv has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def to_csv
    fields = metadata_fields([], CHILD_IDENTIFIERS) + FormSection.all_visible_child_fields_for_form(model_class::FORM_NAME)
    field_names = fields.map { |field| field.display_name }
    csv_data = CSV.generate do |rows|
      rows << field_names + CHILD_STATUS + metadata_fields([], CHILD_METADATA).map { |field| field.display_name }
    Severity: Minor
    Found in lib/export_generator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    IdleSessionTimeout.start = function() {
    var dialog_buttons = {};
    dialog_buttons[I18n.t("messages.keep_working")] = function () {$(this).dialog('close');};
    dialog_buttons[I18n.t("cancel")] = function () {$.idleTimeout.options.onTimeout.call(this);};
    $("#dialog").dialog({
    Severity: Minor
    Found in app/assets/javascripts/session_timeout.js - About 1 hr to fix

      Method index has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def index
    authorize! :index, Child

    @page_name = t('home.view_records')
    @aside = 'shared/sidebar_links'
      Severity: Minor
      Found in app/controllers/children_controller.rb - About 1 hr to fix

        Method initialize_child_permissions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize_child_permissions(user)
    if user.has_permission?(Permission::CHILDREN[:register])
      can [:create], Child
      can [:read], Child do |child|
        child.created_by == user.user_name
        Severity: Minor
        Found in app/models/ability.rb - About 1 hr to fix

          Method build_details_of_interview_section has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def self.build_details_of_interview_section
      details_of_interview_fields = [
        Field.new('name' => '6_name',
                  'type' => 'text_field',
                  'display_name_all' => 'Name'
          Severity: Minor
          Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              def respond_to_export(format, children)
    RapidftrAddon::ExportTask.active.each do |export_task|
      format.any(export_task.id) do
        authorize! "export_#{export_task.id}".to_sym, Child
        LogEntry.create! :type => LogEntry::TYPE[export_task.id], :user_name => current_user.user_name, :organisation => current_user.organisation, :child_ids => children.map(&:id)
            Severity: Major
            Found in app/controllers/children_controller.rb and 2 other locations - About 1 hr to fix
            app/controllers/enquiries_controller.rb on lines 121..127
            app/controllers/search_controller.rb on lines 48..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              def respond_to_export(format, children)
    RapidftrAddon::ExportTask.active.each do |export_task|
      format.any(export_task.id) do
        authorize! "export_#{export_task.id}".to_sym, Child
        LogEntry.create! :type => LogEntry::TYPE[export_task.id], :user_name => current_user.user_name, :organisation => current_user.organisation, :child_ids => children.map(&:id)
            Severity: Major
            Found in app/controllers/search_controller.rb and 2 other locations - About 1 hr to fix
            app/controllers/children_controller.rb on lines 268..274
            app/controllers/enquiries_controller.rb on lines 121..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              def respond_to_export(format, enquiries)
    RapidftrAddon::ExportTask.active.each do |export_task|
      format.any(export_task.id) do
        authorize! "export_#{export_task.id}".to_sym, Enquiry
        LogEntry.create! :type => LogEntry::TYPE[export_task.id], :user_name => current_user.user_name, :organisation => current_user.organisation, :enquiry_ids => enquiries.map(&:id)
            Severity: Major
            Found in app/controllers/enquiries_controller.rb and 2 other locations - About 1 hr to fix
            app/controllers/children_controller.rb on lines 268..274
            app/controllers/search_controller.rb on lines 48..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method authenticate_user has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def authenticate_user
    user = User.find_by_user_name(@user_name)
    if user && user.authenticate(@password)
      mobile_login_history = user.mobile_login_history.first
      imei = mobile_login_history.nil? ? '' : mobile_login_history['imei']
            Severity: Minor
            Found in app/models/login.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method return_partial_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def return_partial_hash(change, field, history, model = nil)
    if field == 'photo_keys'
      return {:partial => 'shared/histories/photo_history_change',
              :locals => {
                :new_photos => change['added'],
            Severity: Minor
            Found in app/helpers/histories_helper.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method mark_or_unmark_as_reunited has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def mark_or_unmark_as_reunited(reunited)
    without_updating_matches do
      Enquiry.skip_callback(:save, :after, :find_matching_children)
      self['reunited'] = reunited
      save!
            Severity: Minor
            Found in app/models/enquiry.rb - About 1 hr to fix

              Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def update
    respond_to do |format|
      format.json do
        params[:child] = JSON.parse(params[:child]) if params[:child].is_a?(String)
        child = update_child_from params
              Severity: Minor
              Found in app/controllers/children_controller.rb - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def self.build_photo_audio_section
      photo_audio_fields = [
        Field.new('name' => '7_current_photo_key',
                   'type' => 'photo_upload_box', 'editable' => false,
                   'display_name_all' => 'Current Photo Key'
                Severity: Minor
                Found in lib/rapid_ftr/enquiries_form_section_setup.rb and 1 other location - About 55 mins to fix
                lib/rapid_ftr/children_form_section_setup.rb on lines 576..593

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def self.build_photo_audio_section
      photo_audio_fields = [
        Field.new('name' => 'current_photo_key',
                   'type' => 'photo_upload_box', 'editable' => false,
                   'display_name_all' => 'Current Photo Key'
                Severity: Minor
                Found in lib/rapid_ftr/children_form_section_setup.rb and 1 other location - About 55 mins to fix
                lib/rapid_ftr/enquiries_form_section_setup.rb on lines 344..361

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method sync_unverified has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def sync_unverified
    params[:child] = JSON.parse(params[:child]) if params[:child].is_a?(String)
    params[:child][:photo] = params[:current_photo_key] unless params[:current_photo_key].nil?
    if params[:child][:_id]
      child = Child.get(params[:child][:_id])
                Severity: Minor
                Found in app/controllers/children_controller.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def index
    authorize! :index, Enquiry

    @page_name = t('home.view_records')
    @filter = params[:filter] || nil
                Severity: Minor
                Found in app/controllers/enquiries_controller.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method update_from has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def update_from(properties)
    attributes_to_update = {}
    properties.each_pair do |name, value|
      if value.instance_of?(HashWithIndifferentAccess) || value.instance_of?(ActionController::Parameters)
        attributes_to_update[name] = self[name] if attributes_to_update[name].nil?
                Severity: Minor
                Found in app/models/enquiry.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method initialize_child_permissions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def initialize_child_permissions(user)
    if user.has_permission?(Permission::CHILDREN[:register])
      can [:create], Child
      can [:read], Child do |child|
        child.created_by == user.user_name
                Severity: Minor
                Found in app/models/ability.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language