Sign upLogin

rapidftr/RapidFTR

View on GitHub
Star
lib/rapid_ftr/enquiries_form_section_setup.rb

Summary

Maintainability
D
2 days
Test Coverage

File enquiries_form_section_setup.rb has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module RapidFTR
  module EnquiriesFormSectionSetup
    def self.build_form_sections
      form_sections = []
      form_sections << build_details_of_adult_seeking_child_section
Severity: Minor
Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 4 hrs to fix

    Method build_details_of_adult_seeking_child_section has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.build_details_of_adult_seeking_child_section
      details_of_adult_seeking_child_fields = [
        Field.new('name' => 'enq_first_name',
                  'type' => 'text_field',
                  'highlight_information' => HighlightInformation.new('highlighted' => true, 'order' => 1),
    Severity: Major
    Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 2 hrs to fix

      Method build_details_of_child_sought_fields_section has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.build_details_of_child_sought_fields_section
      details_of_child_sought_fields = [
        Field.new('name' => '2_first_name',
                  'type' => 'text_field',
                  'display_name_all' => 'First Name',
      Severity: Major
      Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 2 hrs to fix

        Method build_family_details_section has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.build_family_details_section
      family_details_fields = [
        Field.new('name' => '3_father_first_name',
                  'type' => 'text_field',
                  'display_name_all' => 'Child\'s Father - First Name',
        Severity: Major
        Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 2 hrs to fix

          Method build_separation_history_section has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def self.build_separation_history_section
      separation_history_fields = [
        Field.new('name' => '4_permanent_address',
                  'type' => 'text_field',
                  'display_name_all' => 'Permanent address prior to separation',
          Severity: Minor
          Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 1 hr to fix

            Method build_details_of_interview_section has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def self.build_details_of_interview_section
      details_of_interview_fields = [
        Field.new('name' => '6_name',
                  'type' => 'text_field',
                  'display_name_all' => 'Name'
            Severity: Minor
            Found in lib/rapid_ftr/enquiries_form_section_setup.rb - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.build_photo_audio_section
      photo_audio_fields = [
        Field.new('name' => '7_current_photo_key',
                   'type' => 'photo_upload_box', 'editable' => false,
                   'display_name_all' => 'Current Photo Key'
              Severity: Minor
              Found in lib/rapid_ftr/enquiries_form_section_setup.rb and 1 other location - About 55 mins to fix
              lib/rapid_ftr/children_form_section_setup.rb on lines 576..593

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.reset_form
      FormSection.all.each { |f| f.destroy  if f.form.name == Enquiry::FORM_NAME  }
      Form.all.each { |f| f.destroy if f.name == Enquiry::FORM_NAME }
      Form.create(:_id => '7caed4ef-4001-44d7-977b-529e934ea1db', :name => Enquiry::FORM_NAME)
              Severity: Minor
              Found in lib/rapid_ftr/enquiries_form_section_setup.rb and 1 other location - About 40 mins to fix
              lib/rapid_ftr/children_form_section_setup.rb on lines 19..22

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status