Sign upLogin

raspi/muuri

View on GitHub
Star

Showing 13 of 13 total issues

Cyclomatic complexity is too high in method login. (13)
Open

    @view_config(route_name='login', renderer='templates/login.pt')
    def login(self):
        from pyramid.httpexceptions import HTTPFound

        if self.request.authenticated_userid is not None:
Severity: Minor
Found in muuri/views/views.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function login has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def login(self):
        from pyramid.httpexceptions import HTTPFound

        if self.request.authenticated_userid is not None:
            # Already logged in -> redirect
Severity: Minor
Found in muuri/views/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_localized_route has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def add_localized_route(config, name, pattern, factory=AppRootFactory, pregenerator=None, **kw):
Severity: Minor
Found in muuri/include/urli18n.py - About 45 mins to fix

    Function dberror_interface_err has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def dberror_interface_err(exc: dberr_interface, request: Request):
    msg = ""
    request.response.status = 500

    args = getattr(exc.orig, 'args', [])
    Severity: Minor
    Found in muuri/views/dberrors.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_localized_route has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def add_localized_route(config, name, pattern, factory=AppRootFactory, pregenerator=None, **kw):
    orig_factory = factory

    def wrapper_factory(request: Request):
        lang = request.matchdict['lang']
    Severity: Minor
    Found in muuri/include/urli18n.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, apitype: int = -1, apikey: str = "", password: str = "", host: str = "", port: int = -1):
    Severity: Minor
    Found in muuri/database/dnsapi.py - About 35 mins to fix

      Function add_api has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def add_api(self, apitype: int = -1, apikey: str = "", host: str = "", port: int = -1, password: str = ""):
      Severity: Minor
      Found in muuri/models/dnsapi.py - About 35 mins to fix

        Avoid too many return statements within this function.
        Open

                    return user_not_found_error
        Severity: Major
        Found in muuri/views/views.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return HTTPFound(self.request.route_path('home'))
          Severity: Major
          Found in muuri/views/views.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return response
            Severity: Major
            Found in muuri/views/views.py - About 30 mins to fix

              Ambiguous variable name 'l'
              Open

                      l = []
              Severity: Minor
              Found in muuri/views/dnsapi.py by pep8

              Never use the characters 'l', 'O', or 'I' as variable names.

              In some fonts, these characters are indistinguishable from the
numerals one and zero. When tempted to use 'l', use 'L' instead.

Okay: L = 0
Okay: o = 123
Okay: i = 42
E741: l = 0
E741: O = 123
E741: I = 42

Variables can be bound in several other contexts, including class
and function definitions, 'global' and 'nonlocal' statements,
exception handlers, and 'with' and 'for' statements.
In addition, we have a special handling for function parameters.

Okay: except AttributeError as o:
Okay: with lock as L:
Okay: foo(l=12)
Okay: for a in foo(l=12):
E741: except AttributeError as O:
E741: with lock as l:
E741: global I
E741: nonlocal l
E741: def foo(l):
E741: def foo(l=12):
E741: l = foo(l=12)
E741: for l in range(10):
E742: class I(object):
E743: def l(x):

              Do not use bare 'except'
              Open

                      except:
              Severity: Minor
              Found in muuri/views/views.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
Okay: except BaseException:
E722: except:

              Do not use bare 'except'
              Open

                      except:
              Severity: Minor
              Found in muuri/models/user.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
Okay: except BaseException:
E722: except:
              Severity
              Category
              Status
              Source
              Language