rastating/joomlavs

View on GitHub
lib/extension_scanner.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class ExtensionScanner has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class ExtensionScanner < Scanner
  def initialize(target_uri, data_file, opts)
    super(target_uri, opts)
    @data_file = File.join(ExtensionScanner.base_path, data_file)
  end
Severity: Minor
Found in lib/extension_scanner.rb - About 2 hrs to fix

    Method queue_manifest_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def queue_manifest_request(manifest_name, paths, name, path_index, &block)
    Severity: Minor
    Found in lib/extension_scanner.rb - About 35 mins to fix

      Method scan has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def scan(filter)
          return [] unless filter
          extensions = apply_filter(data_file_json, filter)
          detected = []
          lock = Mutex.new
      Severity: Minor
      Found in lib/extension_scanner.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method version_is_vulnerable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.version_is_vulnerable(version, vuln)
          found = false
      
          if vuln['ranges']
            vuln['ranges'].each do |range|
      Severity: Minor
      Found in lib/extension_scanner.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status