Sign upLogin

rastating/wordpress-exploit-framework

View on GitHub
Star
data/php/download_exec.php

Summary

Maintainability
A
1 hr
Test Coverage

Function sys_get_temp_dir has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    function sys_get_temp_dir() {
      if (!empty(getenv('TMP'))) { return realpath(getenv('TMP')); }
      if (!empty(getenv('TMPDIR'))) { return realpath(getenv('TMPDIR')); }
      if (!empty(getenv('TEMP'))) { return realpath(getenv('TEMP')); }
Severity: Minor
Found in data/php/download_exec.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return null;
Severity: Major
Found in data/php/download_exec.php - About 30 mins to fix

    Remove error control operator '@' on line 11.
    Open

        function sys_get_temp_dir() {
      if (!empty(getenv('TMP'))) { return realpath(getenv('TMP')); }
      if (!empty(getenv('TMPDIR'))) { return realpath(getenv('TMPDIR')); }
      if (!empty(getenv('TEMP'))) { return realpath(getenv('TEMP')); }
    Severity: Minor
    Found in data/php/download_exec.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    There are no issues that match your filters.

    Category
    Status