rastating/wordpress-exploit-framework

View on GitHub
lib/wpxf/modules/auxiliary/info/download_manager_directory_listing_disclosure.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Assignment Branch Condition size for run is too high. [25.98/15]
Open

  def run
    return false unless super

    listing = [{
      name: 'Name', type: 'Type'

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    return false unless super

    listing = [{
      name: 'Name', type: 'Type'

    Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
        super
    
        update_info(
          name: 'Download Manager Directory Listing Disclosure',

      Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          return false unless super
      
          listing = [{
            name: 'Name', type: 'Type'

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Use match? instead of =~ when MatchData is not used.
      Open

              if item['class'] =~ /directory/

      In Ruby 2.4, String#match?, Regexp#match? and Symbol#match? have been added. The methods are faster than match. Because the methods avoid creating a MatchData object or saving backref. So, when MatchData is not used, use match? instead of match.

      Example:

      # bad
      def foo
        if x =~ /re/
          do_something
        end
      end
      
      # bad
      def foo
        if x.match(/re/)
          do_something
        end
      end
      
      # bad
      def foo
        if /re/ === x
          do_something
        end
      end
      
      # good
      def foo
        if x.match?(/re/)
          do_something
        end
      end
      
      # good
      def foo
        if x =~ /re/
          do_something(Regexp.last_match)
        end
      end
      
      # good
      def foo
        if x.match(/re/)
          do_something($~)
        end
      end
      
      # good
      def foo
        if /re/ === x
          do_something($~)
        end
      end

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

            items = doc.xpath("//ul//li")

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      There are no issues that match your filters.

      Category
      Status