rastating/wordpress-exploit-framework

View on GitHub
lib/wpxf/modules/auxiliary/priv_esc/custom_contact_forms_privilege_escalation.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Assignment Branch Condition size for run is too high. [30.56/15]
Open

  def run
    return false unless super

    emit_info 'Extracting table prefix...'
    prefix = table_prefix

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Perceived complexity for run is too high. [8/7]
Open

  def run
    return false unless super

    emit_info 'Extracting table prefix...'
    prefix = table_prefix

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    return false unless super

    emit_info 'Extracting table prefix...'
    prefix = table_prefix

    Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
        super
    
        update_info(
          name: 'Custom Contact Forms Privilege Escalation',

      Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          return false unless super
      
          emit_info 'Extracting table prefix...'
          prefix = table_prefix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return false

        Use meaningful heredoc delimiters.
        Open

            END_OF_SQL

        This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

        Example:

        # good
        <<-SQL
          SELECT * FROM foo
        SQL
        
        # bad
        <<-END
          SELECT * FROM foo
        END
        
        # bad
        <<-EOS
          SELECT * FROM foo
        EOS

        There are no issues that match your filters.

        Category
        Status