Sign upLogin

rastating/wordpress-exploit-framework

View on GitHub
Star
lib/wpxf/modules/exploit/rfi/gwolle_guestbook_remote_file_inclusion.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for run is too high. [19.44/15]
Open

  def run
    return false unless super

    start_http_server(true)
Severity: Minor
Found in lib/wpxf/modules/exploit/rfi/gwolle_guestbook_remote_file_inclusion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize
    super

    update_info(
      name: 'Gwolle Guestbook Remote File Inclusion',
Severity: Minor
Found in lib/wpxf/modules/exploit/rfi/gwolle_guestbook_remote_file_inclusion.rb - About 1 hr to fix

    Use match? instead of =~ when MatchData is not used.
    Open

        if res.body =~ /allow_url_include/
    Severity: Minor
    Found in lib/wpxf/modules/exploit/rfi/gwolle_guestbook_remote_file_inclusion.rb by rubocop

    In Ruby 2.4, String#match?, Regexp#match? and Symbol#match? have been added. The methods are faster than match. Because the methods avoid creating a MatchData object or saving backref. So, when MatchData is not used, use match? instead of match.

    Example:

    # bad
def foo
  if x =~ /re/
    do_something
  end
end

# bad
def foo
  if x.match(/re/)
    do_something
  end
end

# bad
def foo
  if /re/ === x
    do_something
  end
end

# good
def foo
  if x.match?(/re/)
    do_something
  end
end

# good
def foo
  if x =~ /re/
    do_something(Regexp.last_match)
  end
end

# good
def foo
  if x.match(/re/)
    do_something($~)
  end
end

# good
def foo
  if /re/ === x
    do_something($~)
  end
end

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      def initialize
    super

    update_info(
      name: 'Gwolle Guestbook Remote File Inclusion',
    Severity: Minor
    Found in lib/wpxf/modules/exploit/rfi/gwolle_guestbook_remote_file_inclusion.rb and 4 other locations - About 20 mins to fix
    lib/wpxf/modules/exploit/rfi/advanced_custom_fields_remote_file_inclusion.rb on lines 7..39
    lib/wpxf/modules/exploit/rfi/fast_image_adder_v1.1_rfi_shell_upload.rb on lines 11..47
    lib/wpxf/modules/exploit/rfi/flickr_picture_backup_rfi_shell_upload.rb on lines 8..44
    lib/wpxf/modules/exploit/rfi/wp_mobile_detector_rfi_shell_upload.rb on lines 8..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status