Assignment Branch Condition size for run is too high. [49.53/15] Open
def run
return false unless super
@cookie = authenticate_with_wordpress(datastore['username'], datastore['password'])
return false unless @cookie- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Cyclomatic complexity for run is too high. [11/6] Open
def run
return false unless super
@cookie = authenticate_with_wordpress(datastore['username'], datastore['password'])
return false unless @cookie- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Perceived complexity for run is too high. [12/7] Open
def run
return false unless super
@cookie = authenticate_with_wordpress(datastore['username'], datastore['password'])
return false unless @cookie- Read upRead up
- Exclude checks
This cop tries to produce a complexity score that's a measure of the
complexity the reader experiences when looking at a method. For that
reason it considers when nodes as something that doesn't add as much
complexity as an if or a &&. Except if it's one of those special
case/when constructs where there's no expression after case. Then
the cop treats it as an if/elsif/elsif... and lets all the when
nodes count. In contrast to the CyclomaticComplexity cop, this cop
considers else nodes as adding complexity.
Example:
def my_method # 1
if cond # 1
case var # 2 (0.8 + 4 * 0.2, rounded)
when 1 then func_one
when 2 then func_two
when 3 then func_three
when 4..10 then func_other
end
else # 1
do_something until a && b # 2
end # ===
end # 7 complexity pointsAssignment Branch Condition size for upload_shell is too high. [19.34/15] Open
def upload_shell(username, password)
cookie = authenticate_with_wordpress(username, password)
return false unless cookie
emit_info 'Uploading payload...'- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
def initialize
super
update_info(
name: 'Admin Management Xtended XSS Shell Upload',Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def run
return false unless super
@cookie = authenticate_with_wordpress(datastore['username'], datastore['password'])
return false unless @cookie- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Assignment Branch Condition size for on_http_request is too high. [15.17/15] Open
def on_http_request(path, params, headers)
if params['u'] && params['p']
emit_success "Created a new administrator user, #{params['u']}:#{params['p']}"
stop_http_server
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
def run
return false unless super
@cookie = authenticate_with_wordpress(datastore['username'], datastore['password'])
return false unless @cookieAvoid too many return statements within this method. Open
return @successAvoid too many return statements within this method. Open
return falseAvoid too many return statements within this method. Open
return falseMethod upload_shell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def upload_shell(username, password)
cookie = authenticate_with_wordpress(username, password)
return false unless cookie
emit_info 'Uploading payload...'- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Redundant return detected. Open
return @success- Read upRead up
- Exclude checks
This cop checks for redundant return expressions.
Example:
def test
return something
end
def test
one
two
three
return something
endIt should be extended to handle methods whose body is if/else or a case expression with a default branch.
Redundant return detected. Open
return ''- Read upRead up
- Exclude checks
This cop checks for redundant return expressions.
Example:
def test
return something
end
def test
one
two
three
return something
endIt should be extended to handle methods whose body is if/else or a case expression with a default branch.
Redundant return detected. Open
return wordpress_js_create_user- Read upRead up
- Exclude checks
This cop checks for redundant return expressions.
Example:
def test
return something
end
def test
one
two
three
return something
endIt should be extended to handle methods whose body is if/else or a case expression with a default branch.
Prefer single-quoted strings when you don't need string interpolation or special symbols. Open
emit_success "Script stored and will be executed when a user views the post"- Read upRead up
- Exclude checks
Checks if uses of quotes match the configured preference.
Example: EnforcedStyle: single_quotes (default)
# bad
"No special symbols"
"No string interpolation"
"Just text"
# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"Example: EnforcedStyle: double_quotes
# bad
'Just some text'
'No special chars or interpolation'
# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"