Sign upLogin

rastating/wordpress-exploit-framework

View on GitHub
Star
lib/wpxf/net/user_agent.rb

Summary

Maintainability
A
55 mins
Test Coverage

Module has too many lines. [125/100]
Open

    module UserAgent
      include Wpxf::Versioning::BrowserVersions
      include Wpxf::Versioning::OSVersions

      # A random browser and OS combination.
Severity: Minor
Found in lib/wpxf/net/user_agent.rb by rubocop

This cop checks if the length a module exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for random_user_agent is too high. [16.61/15]
Open

      def random_user_agent
        platform = random_browser_and_os
        os = platform[:os]

        if platform[:browser] == :firefox
Severity: Minor
Found in lib/wpxf/net/user_agent.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for random_browser_and_os is too high. [16.76/15]
Open

      def random_browser_and_os
        frequencies = clients_by_frequency
        target_frequency = rand(1..100)
        sum = 0
Severity: Minor
Found in lib/wpxf/net/user_agent.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Avoid too many return statements within this method.
Open

          return "Mozilla/5.0 #{random_chrome_platform_string(os)}"
Severity: Major
Found in lib/wpxf/net/user_agent.rb - About 30 mins to fix

    Method random_browser_and_os has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def random_browser_and_os
        frequencies = clients_by_frequency
        target_frequency = rand(1..100)
        sum = 0
    Severity: Minor
    Found in lib/wpxf/net/user_agent.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

            if os == :windows
    Severity: Minor
    Found in lib/wpxf/net/user_agent.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

            if os == :windows
    Severity: Minor
    Found in lib/wpxf/net/user_agent.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

            if platform[:browser] == :firefox
    Severity: Minor
    Found in lib/wpxf/net/user_agent.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

    There are no issues that match your filters.

    Category
    Status