Sign upLogin

razielsd/phpSelenide

View on GitHub
Star
lib/Selenide/By.php

Summary

Maintainability
D
2 days
Test Coverage

Method asString has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function asString()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
Severity: Minor
Found in lib/Selenide/By.php - About 1 hr to fix

    Method getChildLocator has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getChildLocator()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
    Severity: Minor
    Found in lib/Selenide/By.php - About 1 hr to fix

      Function escapeString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function escapeString(string $toEscape): string
    {
        if (mb_strpos($toEscape, '"') !== false && mb_strpos($toEscape, "'") !== false) {
            $substringsWithoutDoubleQuotes = explode('"', $toEscape);
      Severity: Minor
      Found in lib/Selenide/By.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getChildLocator has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getChildLocator()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
      Severity: Minor
      Found in lib/Selenide/By.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function asString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function asString()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
      Severity: Minor
      Found in lib/Selenide/By.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function asString()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
      Severity: Major
      Found in lib/Selenide/By.php and 1 other location - About 1 day to fix
      lib/Selenide/By.php on lines 153..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 250.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function getChildLocator()
    {
        $locator = '';
        switch ($this->type) {
            case self::TYPE_NAME:
      Severity: Major
      Found in lib/Selenide/By.php and 1 other location - About 1 day to fix
      lib/Selenide/By.php on lines 116..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 250.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid excessively long variable names like $substringsWithoutDoubleQuotes. Keep variable name length under 20.
      Open

                  $substringsWithoutDoubleQuotes = explode('"', $toEscape);
      Severity: Minor
      Found in lib/Selenide/By.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid using short method names like By::id(). The configured minimum method name length is 3.
      Open

          public static function id($elementId)
    {
        return new static(self::TYPE_ID, $elementId);
    }
      Severity: Minor
      Found in lib/Selenide/By.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid classes with short names like By. Configured minimum length is 3.
      Open

      class By
{

    const TYPE_NAME = 'name';
    const TYPE_TEXT = 'text';
      Severity: Minor
      Found in lib/Selenide/By.php by phpmd

      ShortClassName

      Since: 2.9

      Detects when classes or interfaces have a very short name.

      Example

      class Fo {

}

interface Fo {

}

      Source https://phpmd.org/rules/naming.html#shortclassname

      There are no issues that match your filters.

      Category
      Status