lib/Selenide/Condition/Size.php
Avoid using static access to class '\PHPUnit\Framework\Assert' in method 'assertCollectionNegative'. Open
Open
Assert::assertNotEquals(
$this->expected,
$actualSize,
'Size must be NOT equal ' . $this->expected . ', actual - ' . $actualSize
);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\PHPUnit\Framework\Assert' in method 'assertCollectionPositive'. Open
Open
Assert::assertEquals(
$this->expected,
$actualSize,
'Size must be equal ' . $this->expected . ', actual - ' . $actualSize
);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The class Condition_Size is not named in CamelCase. Open
Open
class Condition_Size extends Condition_Rule
implements Condition_Interface_assertCollection, Condition_Interface_ExpectedCollection
{
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}