lib/Selenide/Selector/Condition.php
The method __construct has a boolean flag argument $isPositive, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct(Condition_Rule $condition, bool $isPositive = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The class Selector_Condition is not named in CamelCase. Open
Open
class Selector_Condition extends Selector
{
protected $condition = null;
protected $isPositive = true;
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}