Sign upLogin

razorbacks/laravel-shibboleth

View on GitHub
Star

Showing 29 of 29 total issues

Avoid using short method names like CreateUsersTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::create('users', function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');
Severity: Minor
Found in src/database/migrations/2014_10_12_000000_create_users_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like CreatePasswordResetsTable::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::create('password_resets', function (Blueprint $table) {
            $table->string('email')->index();
            $table->string('token')->index();
Severity: Minor
Found in src/database/migrations/2014_10_12_100000_create_password_resets_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

            $user = $userClass::create($map);
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

            $map[$local] = $this->getServerVariable($server);
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

            $user->update($map);
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

            $user = $userClass::where('email', '=', $map['email'])->first();
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

            $map['password'] = 'shibboleth';
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

        if (Auth::attempt(array('email' => $map['email']), true)) {
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$map' which will lead to PHP notices.
Open

        if (empty($map['email'])) {
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method idpAuthenticate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function idpAuthenticate()
    {
        if (empty(config('shibboleth.user'))) {
            throw new \Exception('No user attribute mapping for server variables.');
        }
Severity: Minor
Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php - About 1 hr to fix

    Avoid variables with short names like $sp. Configured minimum length is 3.
    Open

        private $sp;
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class ShibbolethController has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
    Open

    class ShibbolethController extends Controller
{
    /**
     * Service Provider
     * @var Shibalike\SP
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Function idpAuthenticate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function idpAuthenticate()
    {
        if (empty(config('shibboleth.user'))) {
            throw new \Exception('No user attribute mapping for server variables.');
        }
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '209', column '20').
    Open

            return new \Shibalike\StateManager\UserlandSession($session);
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '196', column '20').
    Open

            return new \Shibalike\Attr\Store\ArrayStore(config('shibboleth.emulate_idp_users'));
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '52', column '30').
    Open

                $this->idp = new \Shibalike\IdP($stateManager, $this->getAttrStore(), $this->config);
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '20', column '23').
    Open

                throw new \InvalidArgumentException('Entitlement must not be empty.');
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Entitlement.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '81', column '23').
    Open

                throw new \Exception('No user attribute mapping for server variables.');
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '44', column '41').
    Open

                $this->config         = new \Shibalike\Config();
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '49', column '29').
    Open

                $this->sp = new \Shibalike\SP($stateManager, $this->config);
    Severity: Minor
    Found in src/StudentAffairsUwm/Shibboleth/Controllers/ShibbolethController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Severity
    Category
    Status
    Source
    Language