Sign upLogin

rbuv/rbuv-em

View on GitHub
Star

Showing 7 of 7 total issues

Method klass_from_handler has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def self.klass_from_handler(klass = Connection, handler = nil, *args)
      klass = if handler && handler.is_a?(Class)
                raise ArgumentError, "must provide module or subclass of #{klass.name}" unless klass >= handler
                handler
              elsif handler
Severity: Minor
Found in lib/rbuv/em.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bind_connect has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def self.bind_connect bind_addr, bind_port, server, port=nil, handler=nil, *args
      begin
        port = Integer(port)
      rescue ArgumentError, TypeError
        # there was no port, so server must be a unix domain socket
Severity: Minor
Found in lib/rbuv/em.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_server has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.start_server(server, port=nil, handler=nil, *args, &block)
      begin
        port = Integer(port)
      rescue ArgumentError, TypeError
        # there was no port, so server must be a unix domain socket
Severity: Minor
Found in lib/rbuv/em.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bind_connect has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def self.bind_connect bind_addr, bind_port, server, port=nil, handler=nil, *args
Severity: Minor
Found in lib/rbuv/em.rb - About 45 mins to fix

    Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.run(blk=nil, tail=nil, &block)
      tail && @tails.unshift(tail)

      b = blk || block
      if reactor_running?
    Severity: Minor
    Found in lib/rbuv/em.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start_server has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.start_server(server, port=nil, handler=nil, *args, &block)
    Severity: Minor
    Found in lib/rbuv/em.rb - About 35 mins to fix

      Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def self.connect(server, port=nil, handler=nil, *args, &blk)
      Severity: Minor
      Found in lib/rbuv/em.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language