Sign upLogin

rdfio/RDFIO

View on GitHub
Star
classes/parsers/RDFIO_URIToWikiTitleConverter.php

Summary

Maintainability
B
6 hrs
Test Coverage

The class RDFIOURIToTitleConverter has 11 public methods. Consider refactoring RDFIOURIToTitleConverter to keep number of public methods under 10.
Open

class RDFIOURIToTitleConverter { 

    protected $arc2Triples = null;
    protected $arc2ResourceIndex = null;
    protected $arc2NSPrefixes = null;
Severity: Minor
Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Function applyGlobalSettingForPropertiesToUseAsWikiTitle has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    function applyGlobalSettingForPropertiesToUseAsWikiTitle( $uri ) {
        global $rdfiogTitleProperties;

        $title = '';
Severity: Minor
Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function splitURI has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function splitURI( $uri ) {
        global $rdfiogBaseURIs;
        /* ADAPTED FROM ARC2 WITH SOME MODIFICATIONS
         * the following namespaces may lead to conflated URIs,
         * we have to set the split position manually
Severity: Minor
Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method splitURI has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function splitURI( $uri ) {
        global $rdfiogBaseURIs;
        /* ADAPTED FROM ARC2 WITH SOME MODIFICATIONS
         * the following namespaces may lead to conflated URIs,
         * we have to set the split position manually
Severity: Minor
Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return array( $uri, '' );
    Severity: Major
    Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 30 mins to fix

      Function abbreviateParserNSPrefixes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          function abbreviateParserNSPrefixes( $uri, $nsPrefixes ) {
        foreach ( $nsPrefixes as $namespace => $prefix ) {
            $nslength = strlen( $namespace );
            $basepart = '';
            $localpart = '';
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '23', column '26').
      Open

              $this->arc2Store = new RDFIOARC2StoreWrapper();
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '304', column '26').
      Open

                  $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $this->arc2Triples, $this->arc2ResourceIndex, $this->arc2NSPrefixes );
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method convert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $this->arc2Triples, $this->arc2ResourceIndex, $this->arc2NSPrefixes );
            $propertyTitle = $uriToTitleConv->convert( $propertyURI );
        }
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid excessively long variable names like $rdfiogTitleProperties. Keep variable name length under 20.
      Open

              global $rdfiogTitleProperties;
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $rdfiogTitleProperties. Keep variable name length under 20.
      Open

              global $rdfiogTitleProperties;
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $rdfiogTitleProperties. Keep variable name length under 20.
      Open

              global $rdfiogTitleProperties;
      Severity: Minor
      Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status