Sign upLogin

rdfio/RDFIO

View on GitHub
Star

Showing 158 of 158 total issues

Missing class import via use statement (line '125', column '14').
Open

            throw new Exception( 'Could not extract object from empty string (' . $binding->uri . '), in SPARQLImport' );
Severity: Minor
Found in specials/SpecialSPARQLImport.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '148', column '15').
Open

                throw new RDFIOARC2StoreWrapperException( $error );
Severity: Minor
Found in classes/RDFIO_ARC2StoreWrapper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '107', column '24').
Open

        $smwPageWriter = new RDFIOSMWPageWriter();
Severity: Minor
Found in classes/RDFIO_RDFImporter.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function getEquivURIsForURI has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getEquivURIsForURI( $uri ) {
        $equivUris = array();

        $query = 'SELECT ?equivUri WHERE { { <' . $uri . '> <' . self::EQUIV_URI . '> ?equivUri } UNION { <' . $uri . '> <' . self::EQUIV_PROPERTY_URI . '> ?equivUri } }';
        $results = $this->arc2store->query( $query );
Severity: Minor
Found in classes/RDFIO_ARC2StoreWrapper.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function abbreviateParserNSPrefixes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    function abbreviateParserNSPrefixes( $uri, $nsPrefixes ) {
        foreach ( $nsPrefixes as $namespace => $prefix ) {
            $nslength = strlen( $namespace );
            $basepart = '';
            $localpart = '';
Severity: Minor
Found in classes/parsers/RDFIO_URIToWikiTitleConverter.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    function execute( $par ) {
        unset( $par ); // Needed to suppress warning about unused variable which we include just for consistency.

        // Require rdfio-import permission for the current user
        if ( !$this->userCanExecute( $this->getUser() ) ) {
Severity: Minor
Found in specials/SpecialSPARQLImport.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    function execute( $par ) {
        unset( $par ); // Needed to suppress warning about unused variable which we include just for consistency.

        // Require rdfio-admin permission for the current user
        if ( !$this->userCanExecute( $this->getUser() ) ) {
Severity: Minor
Found in specials/SpecialRDFIOAdmin.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extendQueryPatternsWithEquivUriLinks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function extendQueryPatternsWithEquivUriLinks( $patterns ) {
        $patternIdx = 0;
        foreach ( $patterns as $pattern ) {
            $equivUriUris = array(
                's' => $this->storewrapper->getEquivURIURI(),
Severity: Minor
Found in specials/SpecialSPARQLEndpoint.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute( $par ) {
        unset( $par ); // Needed to suppress warning about unused variable which we include just for consistency.

        // Require rdfio-sparql permission for the current user
        if ( !$this->userCanExecute( $this->getUser() ) ) {
Severity: Minor
Found in specials/SpecialSPARQLEndpoint.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildPropertyTemplateParamIndex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function buildPropertyTemplateParamIndex( $newFacts, $allTemplateFacts ) {
        // Build the index
        $propTplIndex = array();
        foreach ( $newFacts  as $fact ) {
            $prop = $fact['p'];
Severity: Minor
Found in classes/RDFIO_SMWPageWriter.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class 'ARC2' in method 'execute'.
Open

        $store = ARC2::getStore( $arc2StoreConfig );
Severity: Minor
Found in specials/SpecialRDFIOAdmin.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method importFromArc2Data uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $otherPages[$pageTitle] = $wikiPage;
            }
Severity: Minor
Found in classes/RDFIO_RDFImporter.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'WikiPage' in method 'getTextForPage'.
Open

        $pageObj = WikiPage::factory( $titleObj );
Severity: Minor
Found in classes/RDFIO_SMWPageWriter.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Html' in method 'execute'.
Open

                    Html::Hidden( 'token', $wUser->getEditToken() ) .
Severity: Minor
Found in specials/SpecialRDFIOAdmin.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Title' in method 'writeToPage'.
Open

        $mwTitleObj = Title::newFromText( $wikiTitle );
Severity: Minor
Found in classes/RDFIO_SMWPageWriter.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'insertData'.
Open

    private function insertData( Title $title, $pageid ) {
        $newpage = SMWDataValueFactory::newTypeIDValue( '_wpg' );
        $newpage->setValues( $title->getDBkey(), $title->getNamespace(), $pageid );
        $semdata = $this->getSemanticData( $newpage );
        $this->updateData( $semdata );
Severity: Minor
Found in stores/SMW_ARC2Store.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

The method updateTemplateCalls uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $newTplCallText = str_replace('}}', '|' . $paramName . '=' . $newVal . "\n}}", $oldTplCallText);
                }
Severity: Minor
Found in classes/RDFIO_SMWPageWriter.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method updateData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $objectStr = '""';
            }
Severity: Minor
Found in stores/SMW_ARC2Store.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'SMWDataValueFactory' in method 'changeTitle'.
Open

        $newpage = SMWDataValueFactory::newTypeIDValue( '_wpg' );
Severity: Minor
Found in stores/SMW_ARC2Store.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method toEquivUrisInTriples uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $subjEquivUris = $this->getEquivURIsForURI( $subjUri );
                if ( count( $subjEquivUris ) > 0 ) {
                    $triples[$tripleidx]['s'] = $subjEquivUris[0];
                    $equivUriCache[$subjUri] = $subjEquivUris[0];
Severity: Minor
Found in classes/RDFIO_ARC2StoreWrapper.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language