Sign upLogin

rdfio/RDFIO

View on GitHub
Star
specials/SpecialSPARQLImport.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function import has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function import( $limit = 25, $offset = 0 ) {
        $wOut = $this->getOutput();
        $wRequest = $this->getRequest();

        $externalSparqlUrl = $wRequest->getText( 'extsparqlurl' );
Severity: Minor
Found in specials/SpecialSPARQLImport.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function import( $limit = 25, $offset = 0 ) {
        $wOut = $this->getOutput();
        $wRequest = $this->getRequest();

        $externalSparqlUrl = $wRequest->getText( 'extsparqlurl' );
Severity: Minor
Found in specials/SpecialSPARQLImport.php - About 1 hr to fix

    Method execute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function execute( $par ) {
        unset( $par ); // Needed to suppress warning about unused variable which we include just for consistency.

        // Require rdfio-import permission for the current user
        if ( !$this->userCanExecute( $this->getUser() ) ) {
    Severity: Minor
    Found in specials/SpecialSPARQLImport.php - About 1 hr to fix

      Method getHTMLForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getHTMLForm( $buttonText, $limit, $offset ) {
        global $wgArticlePath;
        $wRequest = $this->getRequest();
        $wUser = $this->getUser();
      Severity: Minor
      Found in specials/SpecialSPARQLImport.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            function execute( $par ) {
        unset( $par ); // Needed to suppress warning about unused variable which we include just for consistency.

        // Require rdfio-import permission for the current user
        if ( !$this->userCanExecute( $this->getUser() ) ) {
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Missing class import via use statement (line '78', column '14').
        Open

                    throw new RDFIOException( wfMessage( 'rdfio-error-invalid-sparql-url' )->parse() );
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '18', column '14').
        Open

                    throw new PermissionsError( 'rdfio-import', array( 'rdfio-specialpage-access-permission-missing' ) );
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '74', column '14').
        Open

                    throw new RDFIOException( wfMessage( 'rdfio-error-empty-sparql-url' )->parse() );
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '44', column '31').
        Open

                        $dataSourceImporter = new RDFIORDFImporter();
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '115', column '22').
        Open

                $rdfImporter = new RDFIORDFImporter();
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '125', column '14').
        Open

                    throw new Exception( 'Could not extract object from empty string (' . $binding->uri . '), in SPARQLImport' );
        Severity: Minor
        Found in specials/SpecialSPARQLImport.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        There are no issues that match your filters.

        Category
        Status