Sign upLogin

rdfio/rdf2smw

View on GitHub
Star
components/iptypes.go

Summary

Maintainability
A
1 hr
Test Coverage

Function NewWikiPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func NewWikiPage(title string, facts []*Fact, categories []*Category, specificCategory *Category, pageType int) *WikiPage {
Severity: Minor
Found in components/iptypes.go - About 35 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func (f *Fact) escapeWikiChars(inStr string) string {
    outStr := str.Replace(inStr, "[", "(", -1)
    outStr = str.Replace(outStr, "]", ")", -1)
    outStr = str.Replace(outStr, "|", ",", -1)
    outStr = str.Replace(outStr, "=", "-", -1)
    Severity: Minor
    Found in components/iptypes.go and 1 other location - About 45 mins to fix
    components/mwxmlcreator.go on lines 165..173

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    exported type Fact should have comment or be unexported
    Open

    type Fact struct {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported method WikiPage.AddCategory should have comment or be unexported
    Open

    func (p *WikiPage) AddCategory(category *Category) {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported function NewFact should have comment or be unexported
    Open

    func NewFact(property string, value string) *Fact {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported type TripleAggregate should have comment or be unexported
    Open

    type TripleAggregate struct {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported method WikiPage.AddFact should have comment or be unexported
    Open

    func (p *WikiPage) AddFact(fact *Fact) {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported method WikiPage.AddFactUnique should have comment or be unexported
    Open

    func (p *WikiPage) AddFactUnique(fact *Fact) {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported method WikiPage.AddCategoryUnique should have comment or be unexported
    Open

    func (p *WikiPage) AddCategoryUnique(category *Category) {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported type Category should have comment or be unexported
    Open

    type Category struct {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported function NewWikiPage should have comment or be unexported
    Open

    func NewWikiPage(title string, facts []*Fact, categories []*Category, specificCategory *Category, pageType int) *WikiPage {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported function NewTripleAggregate should have comment or be unexported
    Open

    func NewTripleAggregate(subj rdf.Subject, triples []rdf.Triple) *TripleAggregate {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported type WikiPage should have comment or be unexported
    Open

    type WikiPage struct {
    Severity: Minor
    Found in components/iptypes.go by golint

    exported function NewCategory should have comment or be unexported
    Open

    func NewCategory(name string) *Category {
    Severity: Minor
    Found in components/iptypes.go by golint

    There are no issues that match your filters.

    Category
    Status