Sign upLogin

reachlocal/boxci

View on GitHub
Star

Showing 12 of 12 total issues

Method test has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test(options)
      File.open('/tmp/boxci.log', 'w') do |f|
        f.write('')
      end
Severity: Major
Found in lib/boxci/tester.rb - About 2 hrs to fix

    Method generate_script has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def generate_script
      snippets = []
      snippets << %q{#!/bin/bash --login}
      snippets << %q{BOXCI_TEST_RESULT=0}
      snippets << <<SNIPPET
    Severity: Minor
    Found in lib/boxci/test_runner.rb - About 1 hr to fix

      Method install_puppet_on_box has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def install_puppet_on_box
      say "Opening SSH tunnel into the box...", :blue if verbose?
      Net::SSH.start("default", nil, {:config => File.join(@project_workspace_folder, "ssh-config.local")}) do |ssh|
        puppet = ssh.exec! "which puppet"
        unless puppet
      Severity: Minor
      Found in lib/boxci/tester.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def continue_and_ignore_on_step_failure(hook_name, step)
      if step && !step.empty?
        <<SNIPPET
# Beginning of '#{hook_name}' step '#{step}'
echo "Running '#{hook_name}' step '#{step}'"
      Severity: Major
      Found in lib/boxci/test_runner.rb and 2 other locations - About 45 mins to fix
      lib/boxci/test_runner.rb on lines 99..115
      lib/boxci/test_runner.rb on lines 118..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def continue_on_step_failure(hook_name, step)
      if step && !step.empty?
        <<SNIPPET
# Beginning of '#{hook_name}' step '#{step}'
echo "Running '#{hook_name}' step '#{step}'"
      Severity: Major
      Found in lib/boxci/test_runner.rb and 2 other locations - About 45 mins to fix
      lib/boxci/test_runner.rb on lines 99..115
      lib/boxci/test_runner.rb on lines 137..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def short_circuit_on_step_failure(hook_name, step)
      if step && !step.empty?
        <<SNIPPET
# Beginning of '#{hook_name}' step '#{step}'
echo "Running '#{hook_name}' step '#{step}'"
      Severity: Major
      Found in lib/boxci/test_runner.rb and 2 other locations - About 45 mins to fix
      lib/boxci/test_runner.rb on lines 118..134
      lib/boxci/test_runner.rb on lines 137..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def generate_short_circuiting_hook_script(hook_name)
      if !Boxci.project_config.send(hook_name.to_sym).empty?
        snippets = []
        Boxci.project_config.send(hook_name.to_sym).each do |step|
          snippets << short_circuit_on_step_failure(hook_name, step)
      Severity: Minor
      Found in lib/boxci/test_runner.rb and 1 other location - About 35 mins to fix
      lib/boxci/test_runner.rb on lines 75..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def generate_continue_and_ignore_hook_script(hook_name)
      if !Boxci.project_config.send(hook_name.to_sym).empty?
        snippets = []
        Boxci.project_config.send(hook_name.to_sym).each do |step|
          snippets << continue_and_ignore_on_step_failure(hook_name, step)
      Severity: Minor
      Found in lib/boxci/test_runner.rb and 1 other location - About 35 mins to fix
      lib/boxci/test_runner.rb on lines 63..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method spin_up_box has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def spin_up_box
      inside @project_workspace_folder do
        if verbose?
          if !run "vagrant up --no-provision --provider #{provider}", :verbose => verbose?
            raise Boxci::CommandFailed, "Failed to successfully run vagrant up --no-provision --provider #{provider}"
      Severity: Minor
      Found in lib/boxci/tester.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setup_ssh_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def setup_ssh_config
      inside @project_workspace_folder do
        if verbose?
          if !run "vagrant ssh-config > ssh-config.local", :verbose => verbose?
            raise Boxci::CommandFailed, "Failed to successfully run vagrant ssh-config > ssh-config.local"
      Severity: Minor
      Found in lib/boxci/tester.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module Providers
    class Aws < ::Boxci::Provider
      PLUGIN = {
        :name => "vagrant-aws",
        :dummy_box_url => "https://github.com/mitchellh/vagrant-aws/raw/master/dummy.box"
      Severity: Minor
      Found in lib/boxci/providers/aws.rb and 1 other location - About 25 mins to fix
      lib/boxci/providers/openstack.rb on lines 2..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        module Providers
    class Openstack < ::Boxci::Provider
      PLUGIN = {
        :name => "vagrant-openstack-plugin",
        :dummy_box_url => "https://github.com/cloudbau/vagrant-openstack-plugin/raw/master/dummy.box"
      Severity: Minor
      Found in lib/boxci/providers/openstack.rb and 1 other location - About 25 mins to fix
      lib/boxci/providers/aws.rb on lines 2..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language